git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 3/4] vcs-svn: remove repo_delete wrapper function

From
Jonathan Nieder <jrnieder@gmail.com>
Date
Aug 23, 2017, 00:02 UTC
Message-ID
<20170823000215.GG13924@aiede.mtv.corp.google.com>
In-Reply-To
<20170823000007.GD13924@aiede.mtv.corp.google.com>

Since v1.7.10-rc0~118^2~4^2~4^2~3 (vcs-svn: pass paths through to fast-import, 2010-12-13) this is an alias for fast_export_delete. Remove the unnecessary layer of indirection.

No functional change intended.
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
---
Unchanged.
 vcs-svn/repo_tree.c | 5 -----
 vcs-svn/repo_tree.h | 1 -
 vcs-svn/svndump.c   | 4 ++--
 3 files changed, 2 insertions(+), 8 deletions(-)
diff --git a/vcs-svn/repo_tree.c b/vcs-svn/repo_tree.c
index 1a6f32d7cb..5bd4977cb6 100644
--- a/vcs-svn/repo_tree.c
+++ b/vcs-svn/repo_tree.c
@@ -41,8 +41,3 @@ void svn_repo_copy(uint32_t revision, const char *src, const char *dst)
 	}
 	fast_export_modify(dst, mode, data.buf);
 }
-
-void svn_repo_delete(const char *path)
-{
-	fast_export_delete(path);
-}
diff --git a/vcs-svn/repo_tree.h b/vcs-svn/repo_tree.h
index c840bc9bae..0cd2761183 100644
--- a/vcs-svn/repo_tree.h
+++ b/vcs-svn/repo_tree.h
@@ -3,6 +3,5 @@
 
 void svn_repo_copy(uint32_t revision, const char *src, const char *dst);
 const char *svn_repo_read_path(const char *path, uint32_t *mode_out);
-void svn_repo_delete(const char *path);
 
 #endif
diff --git a/vcs-svn/svndump.c b/vcs-svn/svndump.c
index c0fa4eb723..41113119bd 100644
--- a/vcs-svn/svndump.c
+++ b/vcs-svn/svndump.c
@@ -225,11 +225,11 @@ static void handle_node(void)
 		if (have_text || have_props || node_ctx.srcRev)
 			die("invalid dump: deletion node has "
 				"copyfrom info, text, or properties");
-		svn_repo_delete(node_ctx.dst.buf);
+		fast_export_delete(node_ctx.dst.buf);
 		return;
 	}
 	if (node_ctx.action == NODEACT_REPLACE) {
-		svn_repo_delete(node_ctx.dst.buf);
+		fast_export_delete(node_ctx.dst.buf);
 		node_ctx.action = NODEACT_ADD;
 	}
 	if (node_ctx.srcRev) {
-- 
2.14.1.342.g6490525c54
Previous: Jonathan NiederNext: Jonathan Nieder
Message 10 of 11 in “vcs-svn: remove repo_tree library”
  1. 0/4 vcs-svn: remove repo_tree libraryJonathan Nieder, Aug 22, 2017
  2. 1/4 vcs-svn: remove prototypes for missing functionsJonathan Nieder, Aug 22, 2017
  3. 2/4 vcs-svn: remove custom mode constantsJonathan Nieder, Aug 22, 2017
  4. 3/4 vcs-svn: remove repo_delete wrapper functionJonathan Nieder, Aug 22, 2017
  5. 4/4 vcs-svn: move remaining repo_tree functions to fast_export.hJonathan Nieder, Aug 22, 2017
  6. Stefan BellerAug 22, 2017
  7. vcs-svn: remove repo_tree libraryJonathan Nieder, Aug 23, 2017
  8. 1/4 vcs-svn: remove more unused prototypes and declarationsJonathan Nieder, Aug 23, 2017
  9. 2/4 vcs-svn: remove custom mode constantsJonathan Nieder, Aug 23, 2017
  10. 3/4 vcs-svn: remove repo_delete wrapper functionJonathan Nieder, Aug 23, 2017
  11. 4/4 vcs-svn: move remaining repo_tree functions to fast_export.hJonathan Nieder, Aug 23, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.