git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/4] vcs-svn: remove prototypes for missing functions

From
Jonathan Nieder <jrnieder@gmail.com>
Date
Aug 22, 2017, 23:38 UTC
Message-ID
<20170822233837.GY13924@aiede.mtv.corp.google.com>
In-Reply-To
<20170822233732.GX13924@aiede.mtv.corp.google.com>

I forgot to remove these prototypes when removing these functions in v1.7.10-rc0~118^2~4^2~5^2~4 (vcs-svn: eliminate repo_tree structure, 2010-12-10).

Noticed by building a new file that included both repo_tree.h and repository.h ("error: conflicting types for 'repo_init'").

Reported-by: brian m. carlson <sandals@crustytoothpaste.net>
Reported-by: Stefan Beller <sbeller@google.com>
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
---
 vcs-svn/repo_tree.h | 10 ----------
 1 file changed, 10 deletions(-)
diff --git a/vcs-svn/repo_tree.h b/vcs-svn/repo_tree.h
index 889c6a3c95..6c2f5f8a00 100644
--- a/vcs-svn/repo_tree.h
+++ b/vcs-svn/repo_tree.h
@@ -1,23 +1,13 @@
 #ifndef REPO_TREE_H_
 #define REPO_TREE_H_
 
-struct strbuf;
-
 #define REPO_MODE_DIR 0040000
 #define REPO_MODE_BLB 0100644
 #define REPO_MODE_EXE 0100755
 #define REPO_MODE_LNK 0120000
 
-uint32_t next_blob_mark(void);
 void repo_copy(uint32_t revision, const char *src, const char *dst);
-void repo_add(const char *path, uint32_t mode, uint32_t blob_mark);
 const char *repo_read_path(const char *path, uint32_t *mode_out);
 void repo_delete(const char *path);
-void repo_commit(uint32_t revision, const char *author,
-		const struct strbuf *log, const char *uuid, const char *url,
-		long unsigned timestamp);
-void repo_diff(uint32_t r1, uint32_t r2);
-void repo_init(void);
-void repo_reset(void);
 
 #endif
-- 
2.14.1.342.g6490525c54
Previous: Jonathan NiederNext: Jonathan Nieder
Message 2 of 11 in “vcs-svn: remove repo_tree library”
  1. 0/4 vcs-svn: remove repo_tree libraryJonathan Nieder, Aug 22, 2017
  2. 1/4 vcs-svn: remove prototypes for missing functionsJonathan Nieder, Aug 22, 2017
  3. 2/4 vcs-svn: remove custom mode constantsJonathan Nieder, Aug 22, 2017
  4. 3/4 vcs-svn: remove repo_delete wrapper functionJonathan Nieder, Aug 22, 2017
  5. 4/4 vcs-svn: move remaining repo_tree functions to fast_export.hJonathan Nieder, Aug 22, 2017
  6. Stefan BellerAug 22, 2017
  7. vcs-svn: remove repo_tree libraryJonathan Nieder, Aug 23, 2017
  8. 1/4 vcs-svn: remove more unused prototypes and declarationsJonathan Nieder, Aug 23, 2017
  9. 2/4 vcs-svn: remove custom mode constantsJonathan Nieder, Aug 23, 2017
  10. 3/4 vcs-svn: remove repo_delete wrapper functionJonathan Nieder, Aug 23, 2017
  11. 4/4 vcs-svn: move remaining repo_tree functions to fast_export.hJonathan Nieder, Aug 23, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.