git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 0/4] vcs-svn: remove repo_tree library

From
Jonathan Nieder <jrnieder@gmail.com>
Date
Aug 22, 2017, 23:37 UTC
Message-ID
<20170822233732.GX13924@aiede.mtv.corp.google.com>
Hi,

Stefan noticed that repo_init from vcs-svn/repo_tree.h conflicts with repository.h[1]. Earlier brian m. carlson noticed the same thing[2].

Originally repo_tree.h was used to manage an in-memory representation of the state of the svn tree being imported. When that in-memory representation was retired, we were lazy and left some utility functions there. Here is a patch series to finish cleaning up and remove vcs-svn/repo_tree.h completely.

This is an alternative to bc/vcs-svn-cleanup from 'next'. Those patches weren't cc-ed to me and I missed them --- sorry about that. I can rebase on top of them if that is more convenient.

Thoughts of all kinds welcome, as always.

Thanks, Jonathan

Jonathan Nieder (4):
  vcs-svn: remove prototypes for missing functions
  vcs-svn: remove custom mode constants
  vcs-svn: remove repo_delete wrapper function
  vcs-svn: move remaining repo_tree functions to fast_export.h
 Makefile              |  1 -
 vcs-svn/fast_export.c | 41 +++++++++++++++++++++++++++++++++++++----
 vcs-svn/fast_export.h |  3 +++
 vcs-svn/repo_tree.c   | 48 ------------------------------------------------
 vcs-svn/repo_tree.h   | 23 -----------------------
 vcs-svn/svndump.c     | 33 ++++++++++++++++-----------------
 6 files changed, 56 insertions(+), 93 deletions(-)
 delete mode 100644 vcs-svn/repo_tree.c
 delete mode 100644 vcs-svn/repo_tree.h

[1] https://public-inbox.org/git/20170822213501.5928-1-sbeller@google.com [2] https://public-inbox.org/git/20170821000022.26729-3-sandals@crustytoothpaste.net

Next: Jonathan Nieder
Message 1 of 11 in “vcs-svn: remove repo_tree library”
  1. 0/4 vcs-svn: remove repo_tree libraryJonathan Nieder, Aug 22, 2017
  2. 1/4 vcs-svn: remove prototypes for missing functionsJonathan Nieder, Aug 22, 2017
  3. 2/4 vcs-svn: remove custom mode constantsJonathan Nieder, Aug 22, 2017
  4. 3/4 vcs-svn: remove repo_delete wrapper functionJonathan Nieder, Aug 22, 2017
  5. 4/4 vcs-svn: move remaining repo_tree functions to fast_export.hJonathan Nieder, Aug 22, 2017
  6. Stefan BellerAug 22, 2017
  7. vcs-svn: remove repo_tree libraryJonathan Nieder, Aug 23, 2017
  8. 1/4 vcs-svn: remove more unused prototypes and declarationsJonathan Nieder, Aug 23, 2017
  9. 2/4 vcs-svn: remove custom mode constantsJonathan Nieder, Aug 23, 2017
  10. 3/4 vcs-svn: remove repo_delete wrapper functionJonathan Nieder, Aug 23, 2017
  11. 4/4 vcs-svn: move remaining repo_tree functions to fast_export.hJonathan Nieder, Aug 23, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.