Re: [PATCH 08/16] update submodules: add depopulate_submodule

From: Stefan Beller <sbeller@google.com>
Date: Nov 18, 2016, 18:25 UTC
Message-ID: <CAGZ79kYD0ER4k6+o=spnCS3ymOnTcZ5i7Lu5-G_GLXu6XDqS3Q@mail.gmail.com>
In-Reply-To: <20161118174607.GP66382@google.com>

On Fri, Nov 18, 2016 at 9:46 AM, Brandon Williams <bmwill@google.com> wrote:

Show 5 quoted lines

>> +
>> +       sub = submodule_from_path(null_sha1, path);
>
> This should probably be checked to see if sub not NULL before
> dereferencing it right?

yeah, will fix.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.