Re: [PATCH 02/16] submodule: modernize ok_to_remove_submodule to use argv_array

From: Stefan Beller <sbeller@google.com>
Date: Nov 17, 2016, 18:36 UTC
Message-ID: <CAGZ79kbStcBguwuoTD4bXch4NmAaSLuEPTLW_hGM=PLe2g9upQ@mail.gmail.com>
In-Reply-To: <xmqqwpg3p7rm.fsf@gitster.mtv.corp.google.com>

On Wed, Nov 16, 2016 at 11:03 AM, Junio C Hamano <gitster@pobox.com> wrote:

Show 10 quoted lines

> David Turner <David.Turner@twosigma.com> writes:
>
>>> -            "-u",
>> ...
>>> +    argv_array_pushl(&cp.args, "status", "--porcelain", "-uall",
>>
>> This also changes -u to -uall, which is not mentioned in the
>> commit message.  That should probably be called out.
>
> Or not making that change at all.  Isn't "-u" the same as "-uall"?

Yes it is. My original line of thinking was to have it spelled out clearly in case it changes in the future, but then we could argue that the --porcelain parameter ought to keep the default of -u to "all".

I'll undo that change then.

Thanks, Stefan