From: Stefan Beller Date: Fri, 18 Nov 2016 18:25:31 GMT Subject: Re: [PATCH 08/16] update submodules: add depopulate_submodule Message-ID: In-Reply-To: <20161118174607.GP66382@google.com> On Fri, Nov 18, 2016 at 9:46 AM, Brandon Williams wrote: >> + >> + sub = submodule_from_path(null_sha1, path); > > This should probably be checked to see if sub not NULL before > dereferencing it right? yeah, will fix.