Re: [PATCH 07/16] update submodules: introduce submodule_is_interesting
- From
Stefan Beller <sbeller@google.com>
- Date
- Nov 17, 2016, 20:08 UTC
- Message-ID
- <CAGZ79kYEdA6crWTf3ZW2EthenZA4=PeWd4HfKnCAKxgZoz54qg@mail.gmail.com>
- In-Reply-To
- <20161117105715.GC39230@book.hvoigt.net>
On Thu, Nov 17, 2016 at 2:57 AM, Heiko Voigt <hvoigt@hvoigt.net> wrote:
> It seems that you are only looking at the submodule config from a > commit. Should a user be able to override this with local configuration? > Haven't looked further in the patchseries so maybe that is somewhere > else?
It turns out that in later patches we pass in null_sha1 only, which is looking at the config and possible overrides.
I'll refactor to take no sha1 argument and use null_sha1 here directly.