Re: [PATCH v3 0/9] archive: Add --recurse-submodules to git-archive command

From: Heather Lapointe <hthralpha@gmail.com>
Date: Oct 28, 2022, 18:18 UTC
Message-ID: <CAFwvh9A7V_OC-63f2mqEot4ybHeDUWQ5hvFUet3K+XCc3Xva_A@mail.gmail.com>
In-Reply-To: <kl6lr0yuqlk0.fsf@chooglen-macbookpro.roam.corp.google.com>

On Wed, Oct 26, 2022 at 6:15 PM Glen Choo <chooglen@google.com> wrote:

Show 13 quoted lines

> The Review Club participants generally agreed that this is a really
> well-structured and easy-to-follow series :) As far as new contributions
> go, this is really good.
>
> I think this series broadly makes sense, i.e.:
>
> - the implementation of plumbing "struct repository" through read_tree()
>   (this might also be really helpful for future work)
> - the interface (using "--recurse-submodules")
> - the expected behavior
>
> So I can see this going through with a bit of polish. The others have
> covered style issues quite thoroughly, so I won't comment on those.

Thank you! I've started looking through a lot of these! I have been a bit swamped with my own work or I would have contributed another patch series by now.