Re: [PATCH v2 0/2] archive: Add --recurse-submodules to git-archive command

From: René Scharfe <l.s.r@web.de>
Date: Oct 14, 2022, 09:47 UTC
Message-ID: <b0d36edc-cd9a-e4a1-3bc1-d35654f4843b@web.de>
In-Reply-To: <183d33ad4dc.b3e5b5ca123845.2982022328880074553@alphaservcomputing.solutions>

Am 13.10.22 um 23:23 schrieb Heather Lapointe:

Show 5 quoted lines

> I had been using checkboxes in github, which look like `- [x]` for
> ones that I have completed. They all got converted into items that
> look like they needed doing via GitGitGadget.
>
> The only remaining one was to update documentation.

I opened https://github.com/html-to-text/node-html-to-text/issues/260 to see if they are willing to support this kind of to-do lists better.

> Does this mean I should create multiple PRs? Or should they just be
> split up into individual commits. I will work off assuming the
> latter.

Right, I meant multiple commits.

> Should each individual patch be completely standalone? (To the point
> where each set, with the previous patches should produce a working
> application? Or is having the patch broken up by groups of changes,
> with some level of expecting the final functionality good?)

Yes, each commit should leave Git in a working state. Adding new global functions that are only used by later commits in the series is fine.

René