From: Heather Lapointe Date: Fri, 28 Oct 2022 18:18:19 GMT Subject: Re: [PATCH v3 0/9] archive: Add --recurse-submodules to git-archive command Message-ID: In-Reply-To: On Wed, Oct 26, 2022 at 6:15 PM Glen Choo wrote: > The Review Club participants generally agreed that this is a really > well-structured and easy-to-follow series :) As far as new contributions > go, this is really good. > > I think this series broadly makes sense, i.e.: > > - the implementation of plumbing "struct repository" through read_tree() > (this might also be really helpful for future work) > - the interface (using "--recurse-submodules") > - the expected behavior > > So I can see this going through with a bit of polish. The others have > covered style issues quite thoroughly, so I won't comment on those. Thank you! I've started looking through a lot of these! I have been a bit swamped with my own work or I would have contributed another patch series by now.