Re: [PATCH v3 3/9] tree: increase test coverage for tree.c

From: Jonathan Tan <jonathantanmy@google.com>
Date: Oct 27, 2022, 18:28 UTC
Message-ID: <20221027182857.1839448-1-jonathantanmy@google.com>
In-Reply-To: <9a07c6932f4c7ef844df1fc4f5b6b9feb1810135.1665973401.git.gitgitgadget@gmail.com>

"Heather Lapointe via GitGitGadget" <gitgitgadget@gmail.com> writes:

Show 7 quoted lines

> +	setup_git_directory();
> +	repo = the_repository;
> +	assert(repo);
> +
> +	parse_pathspec(&pathspec, 0,
> +		       PATHSPEC_PREFER_FULL,
> +		       "", argv);

Here, the repository is hardcoded to be "the_repository", and the C code allows the pathspec to be varied but the shell test code always specifies "." as the pathspec. Given that one of the main points of this series is the repo varying, could the repo be taken in as a CLI argument? The pathspec can be left variable, but if it's not going to change, you might as well hardcode it in the C code.

The existing test cases of a basic one and a recursing one is good, but it would be good also to have one where the repo being passed into the function is not the repo whose directory we're currently executing in (that is, different to the_repository). That way we can test that the function works for arbitrary repositories.