Re: [PATCH v2 5/6] t1502: don't create unused files

From: Øystein Walle <oystwa@gmail.com>
Date: Apr 6, 2023, 08:15 UTC
Message-ID: <CAFaJEqug4bghEMnEQzGDN10EqM8e8iSf5i12AvOm+NZzDCQKOw@mail.gmail.com>
In-Reply-To: <20230403223338.468025-6-rybak.a.v@gmail.com>

Hi Andrei

On Tue, 4 Apr 2023 at 00:33, Andrei Rybak <rybak.a.v@gmail.com> wrote:

Show 8 quoted lines

>
>  test_expect_success 'test --parseopt invalid opt-spec' '
>         test_write_lines x -- "=, x" >spec &&
>         echo "fatal: missing opt-spec before option flags" >expect &&
> -       test_must_fail git rev-parse --parseopt -- >out <spec 2>err &&
> +       test_must_fail git rev-parse --parseopt -- <spec 2>err &&
>         test_cmp expect err
>  '

This is the one that was touched by me. At the time I just cargo-culted other tests. This looks obviously correct to me

For what it's worth:

Acked-by: Øystein Walle <oystwa@gmail.com>

Øsse

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.