[RFC PATCH v2 3/3] t1300: add tests for missing keys

From: Andrei Rybak <rybak.a.v@gmail.com>
Date: Apr 18, 2023, 17:50 UTC
Message-ID: <20230418175034.982433-4-rybak.a.v@gmail.com>
In-Reply-To: <20230418175034.982433-1-rybak.a.v@gmail.com>

There several tests in t1300-config.sh that validate failing invocations of "git config". However, there are no tests that check what happens when "git config" is asked to retrieve a value for a missing key.

Add tests that check this for various combinations of "<section>.<key>". ---

The patch is marked as RFC, because I'm not sure if such a test is useful or not. Even if it is not useful as a test, maybe it would be useful as documentation of behavior for people reading "t1300-config.sh"?

Having multiple tests for different kinds of keys might also be overkill, and just one test for a single key is enough. Conversely, there aren't enough tests -- tests for keys with subsections are missing.

 t/t1300-config.sh | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/t/t1300-config.sh b/t/t1300-config.sh
index 20a15ede5c..a646ddd231 100755
--- a/t/t1300-config.sh
+++ b/t/t1300-config.sh
@@ -98,6 +98,20 @@ test_expect_success 'subsections are not canonicalized by git-config' '
 	test_cmp_config two section.SubSection.key
 '
 
+test_missing_key () {
+	local key=$1
+	local title=$2
+	test_expect_success "value for $title is not printed" "
+		test_must_fail git config $key >out 2>err &&
+		test_must_be_empty out &&
+		test_must_be_empty err
+	"
+}
+
+test_missing_key 'missingsection.missingkey' 'missing section and missing key'
+test_missing_key 'missingsection.penguin' 'missing section and existing key'
+test_missing_key 'section.missingkey' 'existing section and missing key'
+
 cat > .git/config <<\EOF
 [alpha]
 bar = foo

-- 
2.40.0