From: Øystein Walle Date: Thu, 06 Apr 2023 08:15:40 GMT Subject: Re: [PATCH v2 5/6] t1502: don't create unused files Message-ID: In-Reply-To: <20230403223338.468025-6-rybak.a.v@gmail.com> Hi Andrei On Tue, 4 Apr 2023 at 00:33, Andrei Rybak wrote: > > test_expect_success 'test --parseopt invalid opt-spec' ' > test_write_lines x -- "=, x" >spec && > echo "fatal: missing opt-spec before option flags" >expect && > - test_must_fail git rev-parse --parseopt -- >out err && > + test_must_fail git rev-parse --parseopt -- err && > test_cmp expect err > ' This is the one that was touched by me. At the time I just cargo-culted other tests. This looks obviously correct to me For what it's worth: Acked-by: Øystein Walle Øsse