Re: [PATCH v2 1/3] t1300: drop duplicate test

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 18, 2023, 18:37 UTC
Message-ID: <xmqqfs8xdokb.fsf@gitster.g>
In-Reply-To: <20230418175034.982433-2-rybak.a.v@gmail.com>

Andrei Rybak <rybak.a.v@gmail.com> writes:

> There are two almost identical tests called 'git config ignores pairs
> with zero count' in file t1300-config.sh.  Drop the first of these and
> keep the one that contains more assertions.

Good eyes. I can see that the other one catches the error output from the identical command and makes sure it exits silently.

Will queue.  Thanks.

Show 23 quoted lines

> Signed-off-by: Andrei Rybak <rybak.a.v@gmail.com>
> ---
>  t/t1300-config.sh | 7 -------
>  1 file changed, 7 deletions(-)
>
> diff --git a/t/t1300-config.sh b/t/t1300-config.sh
> index 2575279ab8..696dca17c6 100755
> --- a/t/t1300-config.sh
> +++ b/t/t1300-config.sh
> @@ -1458,13 +1458,6 @@ test_expect_success 'git config ignores pairs without count' '
>  	test_must_be_empty error
>  '
>  
> -test_expect_success 'git config ignores pairs with zero count' '
> -	test_must_fail env \
> -		GIT_CONFIG_COUNT=0 \
> -		GIT_CONFIG_KEY_0="pair.one" GIT_CONFIG_VALUE_0="value" \
> -		git config pair.one
> -'
> -
>  test_expect_success 'git config ignores pairs exceeding count' '
>  	GIT_CONFIG_COUNT=1 \
>  		GIT_CONFIG_KEY_0="pair.one" GIT_CONFIG_VALUE_0="value" \