Re: [PATCH 0/3] fixup remaining cvsimport tests
- From
Chris Rorvick <chris@rorvick.com>
- Date
- Jan 20, 2013, 21:17 UTC
- Message-ID
- <CAEUsAPbDTUXhz2BoDOwKCjcLS6BQA=jZ6DME4ZDfTDXRL=ZMqA@mail.gmail.com>
- In-Reply-To
- <20130120192412.GA7498@serenity.lan>
On Sun, Jan 20, 2013 at 1:24 PM, John Keeping <john@keeping.me.uk> wrote:
Show 10 quoted lines
> On Sun, Jan 20, 2013 at 10:57:50AM -0800, Junio C Hamano wrote: >> This is not a noise, though. >> >> Chris, how would we want to proceed? I'd prefer at some point to >> see cvsimport-3 to be in sync when the one patched and tested in >> Eric's repository is proven enough. Will Eric be the gatekeeper, or >> will you be sending patches this way as well? > > In this case the patch was to the C portion of cvsps, not the Python > cvs-import, so not relevant for this particular case.
Oh, I think I misunderstood the question. The only time I passed a patch specifically for git-cvsimport.py directly to Eric was before the his patch was in Junio's repository. Unless I'm mistaken, only the second patch Eric sent was actually imported. Subsequent to this I would have submitted any patches for git-cvsimport.py directly to the git list. I just didn't have any--cvsps had several problems that needed to be worked out before it made sense to look at the importer.
In other words, I don't think Eric should be a gatekeeper of this code.
Chris