git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/3] fixup remaining cvsimport tests

From
John Keeping <john@keeping.me.uk>
Date
Jan 20, 2013, 19:24 UTC
Message-ID
<20130120192412.GA7498@serenity.lan>
In-Reply-To
<7vsj5vlm1d.fsf@alter.siamese.dyndns.org>
On Sun, Jan 20, 2013 at 10:57:50AM -0800, Junio C Hamano wrote:
Show 25 quoted lines
> John Keeping <john@keeping.me.uk> writes:
>> On Sun, Jan 20, 2013 at 09:22:03AM -0600, Chris Rorvick wrote:
>>> On Sun, Jan 20, 2013 at 6:58 AM, John Keeping <john@keeping.me.uk> wrote:
>>>> On Thu, Jan 10, 2013 at 10:27:16PM -0600, Chris Rorvick wrote:
>>>>> These patchs apply on top of of Eric Raymond's cvsimport patch.  7 of 15
>>>>> tests in t9600 fail, one of which is fixed w/ a cvsps patch I've sent
>>>>> to Eric (fixes revision map.)
>>>>
>>>> Did you post the fix for the revision map publicly anywhere?
>>> 
>>> It's in Eric's repo and included in version 3.8:
>>> 
>>> https://gitorious.org/cvsps/cvsps/commit/abe81e1775a8959291f629029513d1b7160bbde6
>>
>> Thanks.  For some reason I thought the fix would be to
>> git-cvsimport-3.py.  Obviously I should have read more carefully.
>>
>> Sorry for the noise.
> 
> This is not a noise, though.
> 
> Chris, how would we want to proceed?  I'd prefer at some point to
> see cvsimport-3 to be in sync when the one patched and tested in
> Eric's repository is proven enough.  Will Eric be the gatekeeper, or
> will you be sending patches this way as well?

In this case the patch was to the C portion of cvsps, not the Python cvs-import, so not relevant for this particular case.

I currently have a set of patches on top of jc/cvsimport-upgrade, which is slightly out-of-sync with git-cvsimport.py in Eric's cvsps repository, because I hadn't realised that the latter existed until about an hour ago.

I haven't decided yet whether to rebase those onto the git-cvsimport.py in the cvsps repository or send them here to apply on top of jc/cvsimport-upgrade. Given that git-cvsimport is a command which has been around for a while and (although this is a complete re-write) the aim of these changes is to keep it working as the upstream project changes, I have a slight preference for keeping git-cvsimport here and recommending that the copy in the cvsps repository is removed.

John
Previous: Junio C HamanoNext: Chris Rorvick
Message 9 of 16 in “fixup remaining cvsimport tests”
  1. 0/3 fixup remaining cvsimport testsChris Rorvick, Jan 11, 2013
  2. 1/3 t/lib-cvs.sh: allow cvsps version 3.x.Chris Rorvick, Jan 11, 2013
  3. 2/3 t9600: fixup for new cvsimportChris Rorvick, Jan 11, 2013
  4. 3/3 t9604: fixup for new cvsimportChris Rorvick, Jan 11, 2013
  5. John KeepingJan 20, 2013
  6. Chris RorvickJan 20, 2013
  7. John KeepingJan 20, 2013
  8. Junio C HamanoJan 20, 2013
  9. John KeepingJan 20, 2013
  10. Chris RorvickJan 20, 2013
  11. Chris RorvickJan 20, 2013
  12. Chris RorvickJan 21, 2013
  13. Eric S. RaymondJan 21, 2013
  14. Michael HaggertyJan 23, 2013
  15. John KeepingJan 23, 2013
  16. Michael HaggertyJan 24, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.