git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 1/2] git-p4: remove "delete" verb

From
Luke Diamand <luke@diamand.org>
Date
Dec 21, 2021, 10:32 UTC
Message-ID
<CAE5ih78dLwqpHChkJ6JWmFYZh58Yca8tWke9Oa8JDzzOGi78AQ@mail.gmail.com>
In-Reply-To
<xmqqh7b3vzgp.fsf@gitster.g>
On Mon, 20 Dec 2021 at 19:38, Junio C Hamano <gitster@pobox.com> wrote:
Show 13 quoted lines
>
> Joel Holdsworth <jholdsworth@nvidia.com> writes:
>
> > The git-p4 "delete" verb is described as "A tool to debug the output of
> > p4 -G". However, the implementation provided is of no useful benefit to
> > either users or developers.
>
> The same comment as 2/2 applies here, too.  This time, however, I
> think it would be much easier to give a proper analysis of what it
> is designed to do and what it does, to convince readers why it is
> too trivial to be worth having the code (compared to the PATCH 2/2).
>
> Also, this is not about the "delete" verb, but the "debug" verb, no?

I have never used the P4Debug subcommand for debugging git-p4, and I'm not sure what I would use it for. Removing it seems sensible.

As noted by Junio, s/delete/debug/.
Luke
Previous: Junio C HamanoNext: Joel Holdsworth
Message 4 of 7 in “git-p4: remove "debug" and "rollback" verbs”
  1. 0/2 git-p4: remove "debug" and "rollback" verbsJoel Holdsworth, Dec 17, 2021
  2. 1/2 git-p4: remove "delete" verbJoel Holdsworth, Dec 17, 2021
  3. Junio C HamanoDec 20, 2021
  4. Luke DiamandDec 21, 2021
  5. 2/2 git-p4: remove "rollback" verbJoel Holdsworth, Dec 17, 2021
  6. Junio C HamanoDec 20, 2021
  7. Johannes SchindelinDec 20, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.