From: Luke Diamand <luke@diamand.org>
Date: Tue, 21 Dec 2021 10:32:25 GMT
Subject: Re: [PATCH v2 1/2] git-p4: remove "delete" verb
Message-ID: <CAE5ih78dLwqpHChkJ6JWmFYZh58Yca8tWke9Oa8JDzzOGi78AQ@mail.gmail.com>
In-Reply-To: <xmqqh7b3vzgp.fsf@gitster.g>

On Mon, 20 Dec 2021 at 19:38, Junio C Hamano <gitster@pobox.com> wrote:
>
> Joel Holdsworth <jholdsworth@nvidia.com> writes:
>
> > The git-p4 "delete" verb is described as "A tool to debug the output of
> > p4 -G". However, the implementation provided is of no useful benefit to
> > either users or developers.
>
> The same comment as 2/2 applies here, too.  This time, however, I
> think it would be much easier to give a proper analysis of what it
> is designed to do and what it does, to convince readers why it is
> too trivial to be worth having the code (compared to the PATCH 2/2).
>
> Also, this is not about the "delete" verb, but the "debug" verb, no?

I have never used the P4Debug subcommand for debugging git-p4, and I'm
not sure what I would use it for. Removing it seems sensible.

As noted by Junio, s/delete/debug/.

Luke