git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 1/2] git-p4: remove "delete" verb

From
Joel Holdsworth <jholdsworth@nvidia.com>
Date
Dec 17, 2021, 14:05 UTC
Message-ID
<20211217140547.2115095-2-jholdsworth@nvidia.com>
In-Reply-To
<20211217140547.2115095-1-jholdsworth@nvidia.com>

The git-p4 "delete" verb is described as "A tool to debug the output of p4 -G". However, the implementation provided is of no useful benefit to either users or developers.

Signed-off-by: Joel Holdsworth <jholdsworth@nvidia.com>
---
Adds Signed-off-by tag
 git-p4.py | 16 ----------------
 1 file changed, 16 deletions(-)
diff --git a/git-p4.py b/git-p4.py
index 2b4500226a..b7ed8e41ff 100755
--- a/git-p4.py
+++ b/git-p4.py
@@ -1532,21 +1532,6 @@ def loadUserMapFromCache(self):
         except IOError:
             self.getUserMapFromPerforceServer()
 
-class P4Debug(Command):
-    def __init__(self):
-        Command.__init__(self)
-        self.options = []
-        self.description = "A tool to debug the output of p4 -G."
-        self.needsGit = False
-
-    def run(self, args):
-        j = 0
-        for output in p4CmdList(args):
-            print('Element: %d' % j)
-            j += 1
-            print(output)
-        return True
-
 class P4RollBack(Command):
     def __init__(self):
         Command.__init__(self)
@@ -4363,7 +4348,6 @@ def printUsage(commands):
     print("")
 
 commands = {
-    "debug" : P4Debug,
     "submit" : P4Submit,
     "commit" : P4Submit,
     "sync" : P4Sync,
-- 
2.34.1
Previous: Joel HoldsworthNext: Junio C Hamano
Message 2 of 7 in “git-p4: remove "debug" and "rollback" verbs”
  1. 0/2 git-p4: remove "debug" and "rollback" verbsJoel Holdsworth, Dec 17, 2021
  2. 1/2 git-p4: remove "delete" verbJoel Holdsworth, Dec 17, 2021
  3. Junio C HamanoDec 20, 2021
  4. Luke DiamandDec 21, 2021
  5. 2/2 git-p4: remove "rollback" verbJoel Holdsworth, Dec 17, 2021
  6. Junio C HamanoDec 20, 2021
  7. Johannes SchindelinDec 20, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.