Re: [PATCH v2 1/2] git-p4: remove "delete" verb

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 20, 2021, 19:38 UTC
Message-ID: <xmqqh7b3vzgp.fsf@gitster.g>
In-Reply-To: <20211217140547.2115095-2-jholdsworth@nvidia.com>

Joel Holdsworth <jholdsworth@nvidia.com> writes:

> The git-p4 "delete" verb is described as "A tool to debug the output of
> p4 -G". However, the implementation provided is of no useful benefit to
> either users or developers.

The same comment as 2/2 applies here, too. This time, however, I think it would be much easier to give a proper analysis of what it is designed to do and what it does, to convince readers why it is too trivial to be worth having the code (compared to the PATCH 2/2).

Also, this is not about the "delete" verb, but the "debug" verb, no?

Show 41 quoted lines

> Signed-off-by: Joel Holdsworth <jholdsworth@nvidia.com>
> ---
> Adds Signed-off-by tag
>
>  git-p4.py | 16 ----------------
>  1 file changed, 16 deletions(-)
>
> diff --git a/git-p4.py b/git-p4.py
> index 2b4500226a..b7ed8e41ff 100755
> --- a/git-p4.py
> +++ b/git-p4.py
> @@ -1532,21 +1532,6 @@ def loadUserMapFromCache(self):
>          except IOError:
>              self.getUserMapFromPerforceServer()
>  
> -class P4Debug(Command):
> -    def __init__(self):
> -        Command.__init__(self)
> -        self.options = []
> -        self.description = "A tool to debug the output of p4 -G."
> -        self.needsGit = False
> -
> -    def run(self, args):
> -        j = 0
> -        for output in p4CmdList(args):
> -            print('Element: %d' % j)
> -            j += 1
> -            print(output)
> -        return True
> -
>  class P4RollBack(Command):
>      def __init__(self):
>          Command.__init__(self)
> @@ -4363,7 +4348,6 @@ def printUsage(commands):
>      print("")
>  
>  commands = {
> -    "debug" : P4Debug,
>      "submit" : P4Submit,
>      "commit" : P4Submit,
>      "sync" : P4Sync,