git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 02/21] Add parse_pathspec() that converts cmdline args to struct pathspec

From
Duy Nguyen <pclouds@gmail.com>
Date
Jan 11, 2013, 02:33 UTC
Message-ID
<CACsJy8DOPZD_zd1cTtrCcvVUU6d7LA7_UNJse4xTcDp4ttP9jQ@mail.gmail.com>
In-Reply-To
<CANiSa6iUqZ7E9NWgMfR3bUxZoyhjO2Jz+Z=yjs9vkfmbit7SOg@mail.gmail.com>

On Fri, Jan 11, 2013 at 6:26 AM, Martin von Zweigbergk <martinvonz@gmail.com> wrote:

Show 15 quoted lines
> On Sat, Jan 5, 2013 at 10:20 PM, Nguyễn Thái Ngọc Duy <pclouds@gmail.com> wrote:
>> +
>> +       /* No arguments, no prefix -> no pathspec */
>> +       if (!entry && !prefix)
>> +               return;
>>
>> +       /* No arguments with prefix -> prefix pathspec */
>
> When working with the old get_pathspec(), I remember wondering if a
> flag switching between "no argument -> prefix pathspec" and "no
> argument -> no pathspec" would be worthwhile. I think e.g. 'add' and
> 'clean' would use the former , while 'reset' and 'commit' would use
> the latter. Since you're now changing all the callers of
> get_pathspec(), it seems like the perfect time to ask this question.
> What do you think?
Yes that'll simplify the call sites. Will do.
-- 
Duy
Previous: Martin von ZweigbergkNext: Nguyễn Thái Ngọc Duy
Message 5 of 26 in “"struct pathspec" conversion”
  1. 00/21 "struct pathspec" conversionNguyễn Thái Ngọc Duy, Jan 6, 2013
  2. 01/21 pathspec: save the non-wildcard length partNguyễn Thái Ngọc Duy, Jan 6, 2013
  3. 02/21 Add parse_pathspec() that converts cmdline args to struct pathspecNguyễn Thái Ngọc Duy, Jan 6, 2013
  4. Martin von ZweigbergkJan 10, 2013
  5. Duy NguyenJan 11, 2013
  6. 03/21 pathspec: make sure the prefix part is wildcard-cleanNguyễn Thái Ngọc Duy, Jan 6, 2013
  7. Duy NguyenJan 7, 2013
  8. 04/21 Export parse_pathspec() and convert some get_pathspec() callsNguyễn Thái Ngọc Duy, Jan 6, 2013
  9. 05/21 clean: convert to use parse_pathspecNguyễn Thái Ngọc Duy, Jan 6, 2013
  10. 06/21 commit: convert to use parse_pathspecNguyễn Thái Ngọc Duy, Jan 6, 2013
  11. 07/21 status: convert to use parse_pathspecNguyễn Thái Ngọc Duy, Jan 6, 2013
  12. 08/21 rerere: convert to use parse_pathspecNguyễn Thái Ngọc Duy, Jan 6, 2013
  13. 09/21 checkout: convert to use parse_pathspecNguyễn Thái Ngọc Duy, Jan 6, 2013
  14. 10/21 rm: convert to use parse_pathspecNguyễn Thái Ngọc Duy, Jan 6, 2013
  15. 11/21 ls-files: convert to use parse_pathspecNguyễn Thái Ngọc Duy, Jan 6, 2013
  16. 12/21 archive: convert to use parse_pathspecNguyễn Thái Ngọc Duy, Jan 6, 2013
  17. 13/21 add: convert to use parse_pathspecNguyễn Thái Ngọc Duy, Jan 6, 2013
  18. 14/21 Convert read_cache_preload() to take struct pathspecNguyễn Thái Ngọc Duy, Jan 6, 2013
  19. 15/21 Convert unmerge_cache to take struct pathspecNguyễn Thái Ngọc Duy, Jan 6, 2013
  20. 16/21 checkout: convert read_tree_some to take struct pathspecNguyễn Thái Ngọc Duy, Jan 6, 2013
  21. 17/21 Convert report_path_error to take struct pathspecNguyễn Thái Ngọc Duy, Jan 6, 2013
  22. 18/21 Convert refresh_index to take struct pathspecNguyễn Thái Ngọc Duy, Jan 6, 2013
  23. 19/21 Convert {read,fill}_directory to take struct pathspecNguyễn Thái Ngọc Duy, Jan 6, 2013
  24. 20/21 Convert add_files_to_cache to take struct pathspecNguyễn Thái Ngọc Duy, Jan 6, 2013
  25. 21/21 Convert more init_pathspec() to parse_pathspec()Nguyễn Thái Ngọc Duy, Jan 6, 2013
  26. Junio C HamanoJan 6, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.