From: Duy Nguyen <pclouds@gmail.com>
Date: Fri, 11 Jan 2013 02:33:48 GMT
Subject: Re: [PATCH 02/21] Add parse_pathspec() that converts cmdline args to struct pathspec
Message-ID: <CACsJy8DOPZD_zd1cTtrCcvVUU6d7LA7_UNJse4xTcDp4ttP9jQ@mail.gmail.com>
In-Reply-To: <CANiSa6iUqZ7E9NWgMfR3bUxZoyhjO2Jz+Z=yjs9vkfmbit7SOg@mail.gmail.com>

On Fri, Jan 11, 2013 at 6:26 AM, Martin von Zweigbergk
<martinvonz@gmail.com> wrote:
> On Sat, Jan 5, 2013 at 10:20 PM, Nguyễn Thái Ngọc Duy <pclouds@gmail.com> wrote:
>> +
>> +       /* No arguments, no prefix -> no pathspec */
>> +       if (!entry && !prefix)
>> +               return;
>>
>> +       /* No arguments with prefix -> prefix pathspec */
>
> When working with the old get_pathspec(), I remember wondering if a
> flag switching between "no argument -> prefix pathspec" and "no
> argument -> no pathspec" would be worthwhile. I think e.g. 'add' and
> 'clean' would use the former , while 'reset' and 'commit' would use
> the latter. Since you're now changing all the callers of
> get_pathspec(), it seems like the perfect time to ask this question.
> What do you think?

Yes that'll simplify the call sites. Will do.
-- 
Duy