git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 03/21] pathspec: make sure the prefix part is wildcard-clean

From
Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Date
Jan 6, 2013, 06:20 UTC
Message-ID
<1357453268-12543-4-git-send-email-pclouds@gmail.com>
In-Reply-To
<1357453268-12543-1-git-send-email-pclouds@gmail.com>

Prefix is the result of Git moving back from current directory to worktree's top directory and it has to prepend all user provided paths so that they become relative to the new current directory. Any wildcards in the prefix should not be treated as such because it's not the user intention. Make sure all wildcards in the prefix part is disabled.

Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
---
 setup.c | 2 ++
 1 file changed, 2 insertions(+)
diff --git a/setup.c b/setup.c
index 4fcdae6..573ef79 100644
--- a/setup.c
+++ b/setup.c
@@ -250,6 +250,8 @@ static unsigned prefix_pathspec(struct pathspec_item *item,
 	*raw = item->match;
 	item->len = strlen(item->match);
 	item->nowildcard_len = simple_length(item->match);
+	if (item->nowildcard_len < prefixlen)
+		item->nowildcard_len = prefixlen;
 	return magic;
 }
 
-- 
1.8.0.rc2.23.g1fb49df
Previous: Duy NguyenNext: Duy Nguyen
Message 6 of 26 in “"struct pathspec" conversion”
  1. 00/21 "struct pathspec" conversionNguyễn Thái Ngọc Duy, Jan 6, 2013
  2. 01/21 pathspec: save the non-wildcard length partNguyễn Thái Ngọc Duy, Jan 6, 2013
  3. 02/21 Add parse_pathspec() that converts cmdline args to struct pathspecNguyễn Thái Ngọc Duy, Jan 6, 2013
  4. Martin von ZweigbergkJan 10, 2013
  5. Duy NguyenJan 11, 2013
  6. 03/21 pathspec: make sure the prefix part is wildcard-cleanNguyễn Thái Ngọc Duy, Jan 6, 2013
  7. Duy NguyenJan 7, 2013
  8. 04/21 Export parse_pathspec() and convert some get_pathspec() callsNguyễn Thái Ngọc Duy, Jan 6, 2013
  9. 05/21 clean: convert to use parse_pathspecNguyễn Thái Ngọc Duy, Jan 6, 2013
  10. 06/21 commit: convert to use parse_pathspecNguyễn Thái Ngọc Duy, Jan 6, 2013
  11. 07/21 status: convert to use parse_pathspecNguyễn Thái Ngọc Duy, Jan 6, 2013
  12. 08/21 rerere: convert to use parse_pathspecNguyễn Thái Ngọc Duy, Jan 6, 2013
  13. 09/21 checkout: convert to use parse_pathspecNguyễn Thái Ngọc Duy, Jan 6, 2013
  14. 10/21 rm: convert to use parse_pathspecNguyễn Thái Ngọc Duy, Jan 6, 2013
  15. 11/21 ls-files: convert to use parse_pathspecNguyễn Thái Ngọc Duy, Jan 6, 2013
  16. 12/21 archive: convert to use parse_pathspecNguyễn Thái Ngọc Duy, Jan 6, 2013
  17. 13/21 add: convert to use parse_pathspecNguyễn Thái Ngọc Duy, Jan 6, 2013
  18. 14/21 Convert read_cache_preload() to take struct pathspecNguyễn Thái Ngọc Duy, Jan 6, 2013
  19. 15/21 Convert unmerge_cache to take struct pathspecNguyễn Thái Ngọc Duy, Jan 6, 2013
  20. 16/21 checkout: convert read_tree_some to take struct pathspecNguyễn Thái Ngọc Duy, Jan 6, 2013
  21. 17/21 Convert report_path_error to take struct pathspecNguyễn Thái Ngọc Duy, Jan 6, 2013
  22. 18/21 Convert refresh_index to take struct pathspecNguyễn Thái Ngọc Duy, Jan 6, 2013
  23. 19/21 Convert {read,fill}_directory to take struct pathspecNguyễn Thái Ngọc Duy, Jan 6, 2013
  24. 20/21 Convert add_files_to_cache to take struct pathspecNguyễn Thái Ngọc Duy, Jan 6, 2013
  25. 21/21 Convert more init_pathspec() to parse_pathspec()Nguyễn Thái Ngọc Duy, Jan 6, 2013
  26. Junio C HamanoJan 6, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.