git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 07/21] status: convert to use parse_pathspec

From
Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Date
Jan 6, 2013, 06:20 UTC
Message-ID
<1357453268-12543-8-git-send-email-pclouds@gmail.com>
In-Reply-To
<1357453268-12543-1-git-send-email-pclouds@gmail.com>
Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
---
 builtin/commit.c |  6 +++---
 wt-status.c      | 17 +++++++----------
 wt-status.h      |  2 +-
 3 files changed, 11 insertions(+), 14 deletions(-)
diff --git a/builtin/commit.c b/builtin/commit.c
index 8410617..b706ebb 100644
--- a/builtin/commit.c
+++ b/builtin/commit.c
@@ -1207,10 +1207,10 @@ int cmd_status(int argc, const char **argv, const char *prefix)
 	if (show_ignored_in_status)
 		s.show_ignored_files = 1;
 	if (*argv)
-		s.pathspec = get_pathspec(prefix, argv);
+		parse_pathspec(&s.pathspec, PATHSPEC_FROMTOP, 0, prefix, argv);
 
-	read_cache_preload(s.pathspec);
-	refresh_index(&the_index, REFRESH_QUIET|REFRESH_UNMERGED, s.pathspec, NULL, NULL);
+	read_cache_preload(s.pathspec.raw);
+	refresh_index(&the_index, REFRESH_QUIET|REFRESH_UNMERGED, s.pathspec.raw, NULL, NULL);
 
 	fd = hold_locked_index(&index_lock, 0);
 	if (0 <= fd)
diff --git a/wt-status.c b/wt-status.c
index 2a9658b..13e6aba 100644
--- a/wt-status.c
+++ b/wt-status.c
@@ -434,7 +434,7 @@ static void wt_status_collect_changes_worktree(struct wt_status *s)
 	}
 	rev.diffopt.format_callback = wt_status_collect_changed_cb;
 	rev.diffopt.format_callback_data = s;
-	init_pathspec(&rev.prune_data, s->pathspec);
+	rev.prune_data = s->pathspec;
 	run_diff_files(&rev, 0);
 }
 
@@ -459,22 +459,20 @@ static void wt_status_collect_changes_index(struct wt_status *s)
 	rev.diffopt.detect_rename = 1;
 	rev.diffopt.rename_limit = 200;
 	rev.diffopt.break_opt = 0;
-	init_pathspec(&rev.prune_data, s->pathspec);
+	rev.prune_data = s->pathspec;
 	run_diff_index(&rev, 1);
 }
 
 static void wt_status_collect_changes_initial(struct wt_status *s)
 {
-	struct pathspec pathspec;
 	int i;
 
-	init_pathspec(&pathspec, s->pathspec);
 	for (i = 0; i < active_nr; i++) {
 		struct string_list_item *it;
 		struct wt_status_change_data *d;
 		struct cache_entry *ce = active_cache[i];
 
-		if (!ce_path_match(ce, &pathspec))
+		if (!ce_path_match(ce, &s->pathspec))
 			continue;
 		it = string_list_insert(&s->change, ce->name);
 		d = it->util;
@@ -489,7 +487,6 @@ static void wt_status_collect_changes_initial(struct wt_status *s)
 		else
 			d->index_status = DIFF_STATUS_ADDED;
 	}
-	free_pathspec(&pathspec);
 }
 
 static void wt_status_collect_untracked(struct wt_status *s)
@@ -505,11 +502,11 @@ static void wt_status_collect_untracked(struct wt_status *s)
 			DIR_SHOW_OTHER_DIRECTORIES | DIR_HIDE_EMPTY_DIRECTORIES;
 	setup_standard_excludes(&dir);
 
-	fill_directory(&dir, s->pathspec);
+	fill_directory(&dir, s->pathspec.raw);
 	for (i = 0; i < dir.nr; i++) {
 		struct dir_entry *ent = dir.entries[i];
 		if (cache_name_is_other(ent->name, ent->len) &&
-		    match_pathspec(s->pathspec, ent->name, ent->len, 0, NULL))
+		    match_pathspec_depth(&s->pathspec, ent->name, ent->len, 0, NULL))
 			string_list_insert(&s->untracked, ent->name);
 		free(ent);
 	}
@@ -517,11 +514,11 @@ static void wt_status_collect_untracked(struct wt_status *s)
 	if (s->show_ignored_files) {
 		dir.nr = 0;
 		dir.flags = DIR_SHOW_IGNORED | DIR_SHOW_OTHER_DIRECTORIES;
-		fill_directory(&dir, s->pathspec);
+		fill_directory(&dir, s->pathspec.raw);
 		for (i = 0; i < dir.nr; i++) {
 			struct dir_entry *ent = dir.entries[i];
 			if (cache_name_is_other(ent->name, ent->len) &&
-			    match_pathspec(s->pathspec, ent->name, ent->len, 0, NULL))
+			    match_pathspec_depth(&s->pathspec, ent->name, ent->len, 0, NULL))
 				string_list_insert(&s->ignored, ent->name);
 			free(ent);
 		}
diff --git a/wt-status.h b/wt-status.h
index 236b41f..dd8df41 100644
--- a/wt-status.h
+++ b/wt-status.h
@@ -44,7 +44,7 @@ struct wt_status {
 	int is_initial;
 	char *branch;
 	const char *reference;
-	const char **pathspec;
+	struct pathspec pathspec;
 	int verbose;
 	int amend;
 	enum commit_whence whence;
-- 
1.8.0.rc2.23.g1fb49df
Previous: Nguyễn Thái Ngọc DuyNext: Nguyễn Thái Ngọc Duy
Message 11 of 26 in “"struct pathspec" conversion”
  1. 00/21 "struct pathspec" conversionNguyễn Thái Ngọc Duy, Jan 6, 2013
  2. 01/21 pathspec: save the non-wildcard length partNguyễn Thái Ngọc Duy, Jan 6, 2013
  3. 02/21 Add parse_pathspec() that converts cmdline args to struct pathspecNguyễn Thái Ngọc Duy, Jan 6, 2013
  4. Martin von ZweigbergkJan 10, 2013
  5. Duy NguyenJan 11, 2013
  6. 03/21 pathspec: make sure the prefix part is wildcard-cleanNguyễn Thái Ngọc Duy, Jan 6, 2013
  7. Duy NguyenJan 7, 2013
  8. 04/21 Export parse_pathspec() and convert some get_pathspec() callsNguyễn Thái Ngọc Duy, Jan 6, 2013
  9. 05/21 clean: convert to use parse_pathspecNguyễn Thái Ngọc Duy, Jan 6, 2013
  10. 06/21 commit: convert to use parse_pathspecNguyễn Thái Ngọc Duy, Jan 6, 2013
  11. 07/21 status: convert to use parse_pathspecNguyễn Thái Ngọc Duy, Jan 6, 2013
  12. 08/21 rerere: convert to use parse_pathspecNguyễn Thái Ngọc Duy, Jan 6, 2013
  13. 09/21 checkout: convert to use parse_pathspecNguyễn Thái Ngọc Duy, Jan 6, 2013
  14. 10/21 rm: convert to use parse_pathspecNguyễn Thái Ngọc Duy, Jan 6, 2013
  15. 11/21 ls-files: convert to use parse_pathspecNguyễn Thái Ngọc Duy, Jan 6, 2013
  16. 12/21 archive: convert to use parse_pathspecNguyễn Thái Ngọc Duy, Jan 6, 2013
  17. 13/21 add: convert to use parse_pathspecNguyễn Thái Ngọc Duy, Jan 6, 2013
  18. 14/21 Convert read_cache_preload() to take struct pathspecNguyễn Thái Ngọc Duy, Jan 6, 2013
  19. 15/21 Convert unmerge_cache to take struct pathspecNguyễn Thái Ngọc Duy, Jan 6, 2013
  20. 16/21 checkout: convert read_tree_some to take struct pathspecNguyễn Thái Ngọc Duy, Jan 6, 2013
  21. 17/21 Convert report_path_error to take struct pathspecNguyễn Thái Ngọc Duy, Jan 6, 2013
  22. 18/21 Convert refresh_index to take struct pathspecNguyễn Thái Ngọc Duy, Jan 6, 2013
  23. 19/21 Convert {read,fill}_directory to take struct pathspecNguyễn Thái Ngọc Duy, Jan 6, 2013
  24. 20/21 Convert add_files_to_cache to take struct pathspecNguyễn Thái Ngọc Duy, Jan 6, 2013
  25. 21/21 Convert more init_pathspec() to parse_pathspec()Nguyễn Thái Ngọc Duy, Jan 6, 2013
  26. Junio C HamanoJan 6, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.