Re: [PATCH] notes: do not accept non-blobs as new notes

From: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Date: May 9, 2012, 08:19 UTC
Message-ID: <CACsJy8DHotHhF0ADDwjUZx5m8SGjXFuXV9fY=mfHmswyZxzeSQ@mail.gmail.com>
In-Reply-To: <20120508160334.GA26838@sigill.intra.peff.net>

On Tue, May 8, 2012 at 11:03 PM, Jeff King <peff@peff.net> wrote:

Show 20 quoted lines

> On Tue, May 08, 2012 at 08:11:32PM +0700, Nguyen Thai Ngoc Duy wrote:
>
>> While at it, check if current notes are blobs before using them.
>
> Hmm. There has been discussion in the past on whether trees could be
> stored in notes. Here's one such thread:
>
>  http://thread.gmane.org/gmane.comp.version-control.git/139165
>
> There didn't seem to be any consensus. It might be a useful concept, but
> it might introduce some complexity. That discussion is two years old
> now, and notes are even older. So I don't know that there is some
> pressing use case that is cut off by disallowing non-blob notes.
>
> At the same time, is there any reason not to allow experimentation in
> this area? We don't know what other people might be putting in their
> private notes trees, and the current interface does allow this.
>
> Is this fixing some important problem that justifies making such
> experimentation harder?

I was actually thinking about tree notes when I made this patch. I decided that if new git supports tree notes while old git does not, the old git should refuse to operate on tree notes so it won't cause any unintentional damages (e.g. appending a blob note to a tree note). It's too late to fix released git though, I don't know what to do in that case.

-- 
Duy