Re: [PATCH 2/4] notes: "add -c" refuses to open an editor with non-blobs
- From
Johannes Sixt <j.sixt@viscovery.net>
- Date
- May 10, 2012, 15:26 UTC
- Message-ID
- <4FABDE2C.30406@viscovery.net>
- In-Reply-To
- <1336658701-9004-3-git-send-email-pclouds@gmail.com>
Am 5/10/2012 16:04, schrieb Nguyễn Thái Ngọc Duy:
> +test_expect_success 'non-blobs cannot be edited using editor' '
> + EDITOR=cat test_must_fail git notes add -f -c HEAD^{tree} (
test_set_editor cat &&
test_must_fail git notes add -f -c HEAD^{tree}
)Ditto in 3/4 and 4/4.
(The problem is not that test_set_editor must be used, but that VAR=value in front of a shell function invocation does not do what you want it to do unless your shell is buggy.)
> +'
-- Hannes