Re: [PATCH] notes: do not accept non-blobs as new notes

From: Jeff King <peff@peff.net>
Date: May 8, 2012, 16:03 UTC
Message-ID: <20120508160334.GA26838@sigill.intra.peff.net>
In-Reply-To: <1336482692-30729-1-git-send-email-pclouds@gmail.com>

On Tue, May 08, 2012 at 08:11:32PM +0700, Nguyen Thai Ngoc Duy wrote:

> While at it, check if current notes are blobs before using them.

Hmm. There has been discussion in the past on whether trees could be stored in notes. Here's one such thread:

  http://thread.gmane.org/gmane.comp.version-control.git/139165

There didn't seem to be any consensus. It might be a useful concept, but it might introduce some complexity. That discussion is two years old now, and notes are even older. So I don't know that there is some pressing use case that is cut off by disallowing non-blob notes.

At the same time, is there any reason not to allow experimentation in this area? We don't know what other people might be putting in their private notes trees, and the current interface does allow this.

Is this fixing some important problem that justifies making such experimentation harder?

-Peff