Re: [PATCH 2/4] notes: "add -c" refuses to open an editor with non-blobs

From: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Date: May 11, 2012, 01:11 UTC
Message-ID: <CACsJy8AhB2fEtTws3rGDi3tQjVa6UivgAZUuQ+yrbp5r10oJUg@mail.gmail.com>
In-Reply-To: <4FABDE2C.30406@viscovery.net>

On Thu, May 10, 2012 at 10:26 PM, Johannes Sixt <j.sixt@viscovery.net> wrote:

Show 14 quoted lines

> Am 5/10/2012 16:04, schrieb Nguyễn Thái Ngọc Duy:
>> +test_expect_success 'non-blobs cannot be edited using editor' '
>> +     EDITOR=cat test_must_fail git notes add -f -c HEAD^{tree}
>
>        (
>                test_set_editor cat &&
>                test_must_fail git notes add -f -c HEAD^{tree}
>        )
>
> Ditto in 3/4 and 4/4.
>
> (The problem is not that test_set_editor must be used, but that VAR=value
> in front of a shell function invocation does not do what you want it to do
> unless your shell is buggy.)

thanks. I looked again and t3301 already exports GIT_EDITOR, so we can skip setting EDITOR again.

>
>> +'
>
> -- Hannes

-- 
Duy