Re: [PATCH v6 00/32] refs backend

From: Duy Nguyen <pclouds@gmail.com>
Date: Feb 25, 2016, 20:31 UTC
Message-ID: <CACsJy8D168eqdwvgLOeOtnD9FuiDLvUV2V9AVNFQPDVPUDZUww@mail.gmail.com>
In-Reply-To: <1456428475.18017.38.camel@twopensource.com>

On Fri, Feb 26, 2016 at 2:27 AM, David Turner <dturner@twopensource.com> wrote:

> but -Wshadow produces a ton of complaints on the rest of git's
> code.   We should probably fix those.

I know, but what I wrote was meant for new code only (e.g. make refs/lmdb-backend.o CFLAGS=-Wshadow is clean). I think renaming the global env and transaction to the_env and the_transaction probably does the trick. Again, this is controversial whether it's a good thing to do. So your choice.

-- 
Duy

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.