From: Duy Nguyen Date: Thu, 25 Feb 2016 20:31:29 GMT Subject: Re: [PATCH v6 00/32] refs backend Message-ID: In-Reply-To: <1456428475.18017.38.camel@twopensource.com> On Fri, Feb 26, 2016 at 2:27 AM, David Turner wrote: > but -Wshadow produces a ton of complaints on the rest of git's > code. We should probably fix those. I know, but what I wrote was meant for new code only (e.g. make refs/lmdb-backend.o CFLAGS=-Wshadow is clean). I think renaming the global env and transaction to the_env and the_transaction probably does the trick. Again, this is controversial whether it's a good thing to do. So your choice. -- Duy