Re: [PATCH v6 00/32] refs backend

From: Duy Nguyen <pclouds@gmail.com>
Date: Feb 25, 2016, 12:57 UTC
Message-ID: <CACsJy8DEtmYnmwENws0Hb_2Do_sQkKEaraz=vxgrCyTOV-3FVg@mail.gmail.com>
In-Reply-To: <1456354744-8022-1-git-send-email-dturner@twopensource.com>

A couple of build warnings I found, haven't really read the code yet. These two can easily be fixed

refs/lmdb-backend.c: In function 'lmdb_read_raw_ref':
refs/lmdb-backend.c:554:16: warning: unused variable 'err' [-Wunused-variable]
  struct strbuf err = STRBUF_INIT;
                ^
refs/lmdb-backend.c: In function 'lmdb_do_for_each_ref':
refs/lmdb-backend.c:1625:15: warning: unused variable 'c' [-Wunused-variable]
   const char *c = resolve_ref_unsafe_submodule(submodule, refname, 0, oid.hash,
               ^

-Wshadow also gives a bunch of warnings, mostly about "transaction" and "env". Whether you want to fix them is really up to you. -- Duy

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.