git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v6 09/32] refs: add do_for_each_per_worktree_ref

From
David Turner <dturner@twopensource.com>
Date
Feb 24, 2016, 22:58 UTC
Message-ID
<1456354744-8022-10-git-send-email-dturner@twopensource.com>
In-Reply-To
<1456354744-8022-1-git-send-email-dturner@twopensource.com>

Alternate refs backends might still use files to store per-worktree refs. So the files backend's ref-loading infrastructure should be available to those backends, just for use on per-worktree refs. Add do_for_each_per_worktree_ref, which iterates over per-worktree refs.

Signed-off-by: David Turner <dturner@twopensource.com>
---
 refs/files-backend.c | 16 ++++++++++++++++
 refs/refs-internal.h |  7 +++++++
 2 files changed, 23 insertions(+)
diff --git a/refs/files-backend.c b/refs/files-backend.c
index db9e948..d315f40 100644
--- a/refs/files-backend.c
+++ b/refs/files-backend.c
@@ -565,6 +565,10 @@ static int do_one_ref(struct ref_entry *entry, void *cb_data)
 	struct ref_entry *old_current_ref;
 	int retval;
 
+	if (data->flags & DO_FOR_EACH_PER_WORKTREE_ONLY &&
+	    ref_type(entry->name) != REF_TYPE_PER_WORKTREE)
+		return 0;
+
 	if (!starts_with(entry->name, data->base))
 		return 0;
 
@@ -1701,6 +1705,18 @@ static int files_do_for_each_ref(const char *submodule, const char *base,
 	return do_for_each_entry(refs, base, do_one_ref, &data);
 }
 
+int do_for_each_per_worktree_ref(const char *submodule, const char *base,
+				 each_ref_fn fn, int trim, int flags,
+				 void *cb_data)
+{
+	/*
+	 * It's important that this one use the files backend, since
+	 *  that's what controls the per-worktree refs
+	 */
+	return files_do_for_each_ref(submodule, base, fn, trim,
+				     flags | DO_FOR_EACH_PER_WORKTREE_ONLY, cb_data);
+}
+
 static void unlock_ref(struct ref_lock *lock)
 {
 	/* Do not free lock->lk -- atexit() still looks at them */
diff --git a/refs/refs-internal.h b/refs/refs-internal.h
index 3702737..bb0d588 100644
--- a/refs/refs-internal.h
+++ b/refs/refs-internal.h
@@ -203,6 +203,13 @@ int rename_ref_available(const char *oldname, const char *newname);
 /* Include broken references in a do_for_each_ref*() iteration: */
 #define DO_FOR_EACH_INCLUDE_BROKEN 0x01
 
+/* Only include per-worktree refs in a do_for_each_ref*() iteration */
+#define DO_FOR_EACH_PER_WORKTREE_ONLY 0x02
+
+int do_for_each_per_worktree_ref(const char *submodule, const char *base,
+				 each_ref_fn fn, int trim, int flags,
+				 void *cb_data);
+
 /* refs backends */
 typedef int ref_transaction_commit_fn(struct ref_transaction *transaction,
 				      struct strbuf *err);
-- 
2.4.2.767.g62658d5-twtrsrc
Previous: David TurnerNext: David Turner
Message 17 of 56 in “refs backend”
  1. 00/32 refs backendDavid Turner, Feb 24, 2016
  2. 01/32 refs: move head_ref{,_submodule} to the common codeDavid Turner, Feb 24, 2016
  3. 02/32 refs: move for_each_*ref* functions into common codeDavid Turner, Feb 24, 2016
  4. 03/32 files-backend: break out ref readingDavid Turner, Feb 24, 2016
  5. Junio C HamanoFeb 25, 2016
  6. Junio C HamanoFeb 25, 2016
  7. David TurnerFeb 25, 2016
  8. Junio C HamanoFeb 25, 2016
  9. 04/32 refs: move resolve_ref_unsafe into common codeDavid Turner, Feb 24, 2016
  10. Junio C HamanoFeb 25, 2016
  11. 05/32 refs: add a backend method structure with transaction functionsDavid Turner, Feb 24, 2016
  12. Jeff KingFeb 27, 2016
  13. David TurnerFeb 29, 2016
  14. 06/32 refs: add methods for misc ref operationsDavid Turner, Feb 24, 2016
  15. 07/32 refs: add method for do_for_each_refDavid Turner, Feb 24, 2016
  16. 08/32 refs: reduce the visibility of do_for_each_ref()David Turner, Feb 24, 2016
  17. 09/32 refs: add do_for_each_per_worktree_refDavid Turner, Feb 24, 2016
  18. 10/32 refs: add methods for reflogDavid Turner, Feb 24, 2016
  19. 11/32 refs: add method for initial ref transaction commitDavid Turner, Feb 24, 2016
  20. 12/32 refs: add method for delete_refsDavid Turner, Feb 24, 2016
  21. 13/32 refs: add methods to init refs dbDavid Turner, Feb 24, 2016
  22. 14/32 refs: add method to rename refsDavid Turner, Feb 24, 2016
  23. 15/32 refs: handle non-normal ref renamesDavid Turner, Feb 24, 2016
  24. 16/32 refs: make lock genericDavid Turner, Feb 24, 2016
  25. 17/32 refs: move duplicate check to common codeDavid Turner, Feb 24, 2016
  26. 18/32 refs: allow log-only updatesDavid Turner, Feb 24, 2016
  27. 19/32 refs: don't dereference on renameDavid Turner, Feb 24, 2016
  28. 20/32 refs: on symref reflog expire, lock symref not referrentDavid Turner, Feb 24, 2016
  29. 21/32 refs: resolve symbolic refs firstDavid Turner, Feb 24, 2016
  30. 22/32 refs: always handle non-normal refs in files backendDavid Turner, Feb 24, 2016
  31. 23/32 init: allow alternate ref strorage to be set for new reposDavid Turner, Feb 24, 2016
  32. 24/32 refs: check submodules' ref storage configDavid Turner, Feb 24, 2016
  33. 25/32 clone: allow ref storage backend to be set for cloneDavid Turner, Feb 24, 2016
  34. 26/32 svn: learn ref-storage argumentDavid Turner, Feb 24, 2016
  35. 27/32 refs: register ref storage backendsDavid Turner, Feb 24, 2016
  36. 28/32 config: read ref storage config on startupDavid Turner, Feb 24, 2016
  37. Jeff KingFeb 27, 2016
  38. Jeff KingFeb 27, 2016
  39. David TurnerFeb 29, 2016
  40. Jeff KingFeb 29, 2016
  41. David TurnerFeb 29, 2016
  42. Jeff KingFeb 29, 2016
  43. Jeff KingFeb 29, 2016
  44. David TurnerFeb 29, 2016
  45. 29/32 refs: break out resolve_ref_unsafe_submoduleDavid Turner, Feb 24, 2016
  46. 30/32 refs: add LMDB refs storage backendDavid Turner, Feb 24, 2016
  47. 31/32 refs: tests for lmdb backendDavid Turner, Feb 24, 2016
  48. 32/32 tests: add ref-storage argumentDavid Turner, Feb 24, 2016
  49. SZEDER GáborFeb 29, 2016
  50. David TurnerFeb 29, 2016
  51. Ramsay JonesFeb 25, 2016
  52. David TurnerFeb 25, 2016
  53. Duy NguyenFeb 25, 2016
  54. David TurnerFeb 25, 2016
  55. Stefan BellerFeb 25, 2016
  56. Duy NguyenFeb 25, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.