Re: [PATCH] For Real - Fixed pluralization in diff reports

From: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Date: Aug 1, 2011, 04:50 UTC
Message-ID: <CACsJy8CdfRCssfrMVOjRn2a_=vZPLyG_uEd4fS2WxzQXKZGn3w@mail.gmail.com>
In-Reply-To: <4E362F8E.1050105@gmail.com>

On Mon, Aug 1, 2011 at 11:46 AM, Jon Forrest <nobozo@gmail.com> wrote:

Show 14 quoted lines

> [I must have accidentally removed the "s" in "deletions" before.
> I just rebuilt everything and remade the patch. All looks well
> this time. This is my first submitted patch to anything
> so my fingers are still learning.]
>
> I got irritated by the
>
>     1 files changed, 0 insertions(+), 1 deletions(-)
>
> lack of pluralization so I fixed it. Now it says
>
>     1 file changed, 0 insertions(+), 1 deletion(-)
>
> and so forth.

Are you sure this does not break any tests? t3508.2 for example hardcodes "1 insertions" and does textual compare. I have not run the tests but I suspect it will fail.

-- 
Duy