Re: [PATCH] For Real - Fixed pluralization in diff reports

From: Jon Forrest <nobozo@gmail.com>
Date: Aug 1, 2011, 14:32 UTC
Message-ID: <4E36B8E4.5080900@gmail.com>
In-Reply-To: <CAGdFq_iwEvD_-hD63KeF45WuRhWrK6JuWWqzDpjHcZ+0gHDaqg@mail.gmail.com>

On 8/1/2011 2:58 AM, Sverre Rabbelier wrote:

Show 14 quoted lines

> Heya,
>
> On Mon, Aug 1, 2011 at 06:46, Jon Forrest<nobozo@gmail.com>  wrote:
>>         fprintf(options->file, "%s", line_prefix);
>>         fprintf(options->file,
>> -              " %d files changed, %d insertions(+), %d deletions(-)\n",
>> -              total_files, adds, dels);
>> +              " %d file%s changed, %d insertion%s(+), %d deletion%s(-)\n",
>> +              total_files, total_files == 1 ? "" : "s", adds, adds == 1 ?
>> "" : "s", dels,
>> +               dels == 1 ? "" : "s");
>>   }
>
> Also, this is rather detrimental to the i18n effort methinks?

If the goal if the i18n effort is also to produce grammatically correct output in all the supported languages then the tests that my patch would break would have to be rewritten anyway.

Jon