git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] For Real - Fixed pluralization in diff reports

From
Jon Forrest <nobozo@gmail.com>
Date
Aug 1, 2011, 18:27 UTC
Message-ID
<4E36F025.9040100@gmail.com>
In-Reply-To
<20110801180603.GB10636@sigill.intra.peff.net>
On 8/1/2011 11:06 AM, Jeff King wrote:
Show 6 quoted lines
>
> I think he means that auto-pluralization like this cannot be done in an
> i18n world, as many languages do not simply add "s". Your patch would
> have to use ngettext, something like this (totally untested and just
> copying a similar spot in suggest_reattach, as I have never done any
> i18n myself):
[snip]
> And that gives translators a chance to specify the entire singular and
> plural versions separately.

I entirely agree. My point is only that the various tests that expect the current behavior will have to be changed whether the implementation of correct plurals uses my inferior method or the way more correct i18n method.

Jon
Previous: Jeff KingNext: Sverre Rabbelier
Message 8 of 12 in “For Real - Fixed pluralization in diff reports”
  1. For Real - Fixed pluralization in diff reportsJon Forrest, Aug 1, 2011
  2. Nguyen Thai Ngoc DuyAug 1, 2011
  3. Jon ForrestAug 1, 2011
  4. Nguyen Thai Ngoc DuyAug 1, 2011
  5. Sverre RabbelierAug 1, 2011
  6. Jon ForrestAug 1, 2011
  7. Jeff KingAug 1, 2011
  8. Jon ForrestAug 1, 2011
  9. Sverre RabbelierAug 1, 2011
  10. Jeff KingAug 1, 2011
  11. Jakub NarebskiAug 3, 2011
  12. Jon ForrestAug 3, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.