git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] For Real - Fixed pluralization in diff reports

From
Jon Forrest <nobozo@gmail.com>
Date
Aug 3, 2011, 16:52 UTC
Message-ID
<4E397CE9.2070500@gmail.com>
In-Reply-To
<m3livdqh9h.fsf@localhost.localdomain>
On 8/3/2011 6:38 AM, Jakub Narebski wrote:
> Jon Forrest<nobozo@gmail.com>  writes:
> Besides, as it was already said, this is an API.

I pretty much only looked at that one file and it didn't look at quick glance like an API was being used to internationalize git.

Show 6 quoted lines
>> If the goal if the i18n effort is also to produce grammatically
>> correct output in all the supported languages then the
>> tests that my patch would break would have to be rewritten
>> anyway.
>
> That's not it.

We can discuss the correct way to implement a change like this but the fact remains that whatever the implementation, the issue that Junio raised will remain. That is, what to do about all the places that presume the old incorrect output.

This problem isn't specific to git. I can easily imagine other open source projects that face, or will face, this problem.

Jon
Previous: Jakub Narebski
Message 12 of 12 in “For Real - Fixed pluralization in diff reports”
  1. For Real - Fixed pluralization in diff reportsJon Forrest, Aug 1, 2011
  2. Nguyen Thai Ngoc DuyAug 1, 2011
  3. Jon ForrestAug 1, 2011
  4. Nguyen Thai Ngoc DuyAug 1, 2011
  5. Sverre RabbelierAug 1, 2011
  6. Jon ForrestAug 1, 2011
  7. Jeff KingAug 1, 2011
  8. Jon ForrestAug 1, 2011
  9. Sverre RabbelierAug 1, 2011
  10. Jeff KingAug 1, 2011
  11. Jakub NarebskiAug 3, 2011
  12. Jon ForrestAug 3, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.