Re: [PATCH/RFC] diff: add --compact-summary option to complement --stat

From: Duy Nguyen <pclouds@gmail.com>
Date: Jan 14, 2018, 10:24 UTC
Message-ID: <CACsJy8BsV9+pxTzTD4mr6ZwThyxir5w2+a4ArqrhBPgyE3q5AA@mail.gmail.com>
In-Reply-To: <20180114093535.GA2518@ruderich.org>

On Sun, Jan 14, 2018 at 4:37 PM, Simon Ruderich <simon@ruderich.org> wrote:

Show 11 quoted lines

> On Sat, Jan 13, 2018 at 08:22:11PM +0700, Nguyễn Thái Ngọc Duy wrote:
>> [snip]
>>
>> For mode changes, executable bit is denoted as "(+x)" or "(-x)" when
>> it's added or removed respectively. The same for when a regular file is
>> replaced with a symlink "(+l)" or the other way "(-l)". This also
>> applies to new files. New regulare files are "A", while new executable
>> files or symlinks are "A+x" or "A+l".
>
> I like the short summary. However I find the use of parentheses
> inconsistent.

I agree. I put them in parentheses because somehow to me plain "+x" looks weird to me.

> Why not use them either always (also for "(A+l)")
> or never? Was there a specific reason why you added them just in
> one place?

Actually shortly after I sent the mail, I realized I could do better. Since this is a mode _modification_, we could denote it with "M" (most files in diffstat are "M" for obvious reasons, we just don't print it because it adds no value), so here we could print "M+x" or "M-x". This aligns well with "A+l" or "A+x" for example and is one character shorter than my old way.

-- 
Duy