git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] diff: add --compact-summary option to complement --stat

From
Jeff King <peff@peff.net>
Date
Jan 19, 2018, 21:53 UTC
Message-ID
<20180119215344.GD12074@sigill.intra.peff.net>
In-Reply-To
<xmqq607xpmty.fsf@gitster.mtv.corp.google.com>
On Fri, Jan 19, 2018 at 01:20:41PM -0800, Junio C Hamano wrote:
Show 22 quoted lines
> >      Documentation/merge-config.txt     |  4 ++
> >      builtin/merge.c                    |  2 +
> >  A+x t/t5573-pull-verify-signatures.sh  | 81 ++++++++++++++++++++++++
> >      t/t7612-merge-verify-signatures.sh | 45 +++++++++++++
> >  4 files changed, 132 insertions(+)
> 
> I like the concept but given that additions and mode changes are
> rare events, I am not so sure if it is worth always wasting three
> columns like the above.  Assuming that this is solely meant for
> human consumption and machine parsability is of no concern, I
> actually prefer the output format you said you've been using your
> personal fork, e.g.
> 
>  Documentation/merge-config.txt              |  4 ++
>  builtin/merge.c                             |  2 +
>  t/t5573-pull-verify-signatures.sh (new, +x) | 81 ++++++++++++++++++++++++
>  t/t7612-merge-verify-signatures.sh          | 45 +++++++++++++
> 
> That is
> 
>  (1) do not change the starting column at the leftmost end, and
>  (2) do not permanently allocate the columns for "compact" summary.

I think the patch already does (2). In fact, it computes the max compact-status size (so if you only have "A" and not "A+x", it wastes only the one column).

I agree that (1) would save space in some cases, though IMHO it's a little hard to notice.

-Peff
Previous: Junio C Hamano
Message 14 of 14 in “diff: add --compact-summary option to complement --stat”
  1. diff: add --compact-summary option to complement --statNguyễn Thái Ngọc Duy, Jan 13, 2018
  2. Philip OakleyJan 13, 2018
  3. Simon RuderichJan 14, 2018
  4. Duy NguyenJan 14, 2018
  5. diff: add --compact-summary option to complement --statNguyễn Thái Ngọc Duy, Jan 18, 2018
  6. Eric SunshineJan 18, 2018
  7. Duy NguyenJan 19, 2018
  8. Ævar Arnfjörð BjarmasonJan 18, 2018
  9. Duy NguyenJan 19, 2018
  10. Jeff KingJan 18, 2018
  11. Duy NguyenJan 19, 2018
  12. Jeff KingJan 19, 2018
  13. Junio C HamanoJan 19, 2018
  14. Jeff KingJan 19, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.