Re: [PATCH v2] diff: add --compact-summary option to complement --stat
- From
Duy Nguyen <pclouds@gmail.com>
- Date
- Jan 19, 2018, 00:01 UTC
- Message-ID
- <CACsJy8B5qrN8T1aai3y3nfEc5baqn2Xkk6vZozMp5Lh-mPZ0VQ@mail.gmail.com>
- In-Reply-To
- <CAPig+cQLgs59JYxcmK30qY307ArwqJx6pNOo95Z39_jJ9+D6+g@mail.gmail.com>
On Fri, Jan 19, 2018 at 1:57 AM, Eric Sunshine <sunshine@sunshineco.com> wrote:
Show 20 quoted lines
>> diff --git a/Documentation/diff-options.txt b/Documentation/diff-options.txt >> @@ -188,6 +188,17 @@ and accumulating child directory counts in the parent directories: >> +--compact-summary:: >> + Output a condensed summary of extended header information in >> + front of the file name part of diffstat. This option is >> + ignored if --stat is not specified. > > Rather than ignoring this option if --stat is not specified, a > different approach would be for --compact-summary to imply --stat. > > Also, per documentation: > > --stat[=<width>[,<name-width>[,<count>]]]:: > > These parameters can also be set individually with `--stat-width=<width>`, > `--stat-name-width=<name-width>` and `--stat-count=<count>`. > > One wonders if "compact" could be another modifier recognized by --stat. > > (Genuine questions/observations; I haven't formed strong opinions either way.)
I left open an option to combine this with other --*stat like numstat (or unlikely, dirstat). I haven't really thought about this. Yeah perhaps putting this in --stat would be a better move. -- Duy