Re: [PATCH] Revert diffstat back to English
On Fri, Sep 14, 2012 at 11:54 PM, Junio C Hamano <junio@pobox.com> wrote:
Show 26 quoted lines
> Junio C Hamano <gitster@pobox.com> writes:
>
>> Nguyễn Thái Ngọc Duy <pclouds@gmail.com> writes:
>>
>>> This reverts the i18n part of 7f81463 (Use correct grammar in diffstat
>>> summary line - 2012-02-01) but still keeps the grammar correctness for
>>> English. It also reverts b354f11 (Fix tests under GETTEXT_POISON on
>>> diffstat - 2012-08-27). The result is diffstat always in English
>>> for all commands.
>>>
>>> This helps stop users from accidentally sending localized
>>> format-patch'd patches.
>>>
>>> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
>
> Why am I getting this from t3300?
>
> --- expected 2012-09-14 16:43:09.000000000 +0000
> +++ current 2012-09-14 16:43:09.000000000 +0000
> @@ -1,2 +1,2 @@
> "tabs\t,\" (dq) and spaces"
> - 1 file changed, 0 insertions(+), 0 deletions(-)
> + 1 files changed, 0 insertion(+), 0 deletion(-)
>
> Ah, your rewrite of Q_() is wrong. Will squash the attached in
> before queueing this for maint.
Arghhh I found that and fixed it, but probably sent an old version. Thanks.
--
Duy
Nguyen Thai Ngoc Duy <pclouds@gmail.com>