Re: [PATCH] Revert diffstat back to English
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Sep 13, 2012, 17:39 UTC
- Message-ID
- <7vzk4t960y.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <1347545786-936-1-git-send-email-pclouds@gmail.com>
Nguyễn Thái Ngọc Duy <pclouds@gmail.com> writes:
> Git is still partly i18n-ized, turning a few strings back does not > seem a big regression.
More than one people explicitly said that they do not want to see this in Klingon. Even if the system is fully internationalized, these "... (+), ... (-)" should never be localized, just like we will never localize "diff --git", "index f00f..abcd", etc.
In other words, it is not a "regression" to begin with. Turning this back to "C" is a bugfix. We shouldn't have had marked it with _() in the first place.
> If you mean projectlang vs a local language, I looked into that and I > don't think we could support two non-C languages using standard > gettext interface. So it's either "C vs another", or make use of > unofficial gettext features, or roll your own.
Yeah, that is true, too.