Re: [PATCH] Makefile: respect $LINGUAS variable on selecting .mo files to install

From: Michael J Gruber <git@drmicha.warpmail.net>
Date: Sep 14, 2012, 13:06 UTC
Message-ID: <50532BCE.6070009@drmicha.warpmail.net>
In-Reply-To: <1347626418-14032-1-git-send-email-pclouds@gmail.com>

Nguyễn Thái Ngọc Duy venit, vidit, dixit 14.09.2012 14:40:

Show 30 quoted lines

> 
> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
> ---
>  On Fri, Sep 14, 2012 at 6:35 PM, Nguyen Thai Ngoc Duy <pclouds@gmail.com> wrote:
>  > We should honor LINGUAS variable on installation. Only languages
>  > listed in that variable are installed. Many if not most of projects do
>  > that already.
> 
>  And here is a try.
> 
>  Makefile | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Makefile b/Makefile
> index 56301dc..eeba645 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -2437,7 +2437,11 @@ po/git.pot: $(LOCALIZED_C)
>  
>  pot: po/git.pot
>  
> +ifdef LINGUAS
> +POFILES := $(shell sh -c "ls $(patsubst %,po/%.po,$(LINGUAS)) 2>/dev/null")
> +else
>  POFILES := $(wildcard po/*.po)
> +endif
>  MOFILES := $(patsubst po/%.po,po/build/locale/%/LC_MESSAGES/git.mo,$(POFILES))
>  
>  ifndef NO_GETTEXT
>

While that may be worthwhile if LINGUAS is some sort of standard I don't think it relates to the discussion at hand. The problem is not the set to choose from but the choice and the specificity of the choice (which parts of the code does it affect).

Michael