Re: [PATCH] Revert diffstat back to English
- From
Jeff King <peff@peff.net>
- Date
- Sep 13, 2012, 21:01 UTC
- Message-ID
- <20120913210111.GA16956@sigill.intra.peff.net>
- In-Reply-To
- <7va9wt9377.fsf@alter.siamese.dyndns.org>
On Thu, Sep 13, 2012 at 11:40:12AM -0700, Junio C Hamano wrote:
Show 8 quoted lines
> > More than one people explicitly said that they do not want to see > > this in Klingon. Even if the system is fully internationalized, > > these "... (+), ... (-)" should never be localized, just like we > > will never localize "diff --git", "index f00f..abcd", etc. > > Nah, I was being silly. People complaining on Klingon on _this_ > list does not argue for this to be in "C"; it just means the > i18n.projectlang for this project is "C".
Right, I think that is the case.
Show 10 quoted lines
> How about _not_ reverting it and doing something like this instead?
> [...]
> +static int project_lang_config(const char *var, const char *value, void *cb_data)
> +{
> + if (!strcmp(var, "i18n.projectlang")) {
> + setenv("LANG", val, 1);
> + setenv("LC_ALL", val, 1);
> + }
> + return 0;
> +}Doesn't that mean that anyone working on git.git will never get to see their localized language, even when it is not likely to be communicated to the rest of the project? I am OK with that as a native speaker, but I wonder what others would have to say.
I suspect we will end up with people not setting i18n.projectlang, and getting Klingon diffstats on the list.
-Peff