git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCHv3] transport: Catch non positive --depth option value

From
Duy Nguyen <pclouds@gmail.com>
Date
Nov 26, 2013, 03:06 UTC
Message-ID
<CACsJy8BV74W63Sak-j_9RMjp_5Bo8HMd3Xc93GTtSn4yWStfEA@mail.gmail.com>
In-Reply-To
<5293DE93.3020008@gmail.com>

On Tue, Nov 26, 2013 at 6:34 AM, "Andrés G. Aragoneses" <knocte@gmail.com> wrote:

Show 14 quoted lines
> On 22/11/13 02:18, Duy Nguyen wrote:
>> On Fri, Nov 22, 2013 at 3:18 AM, Junio C Hamano <gitster@pobox.com> wrote:
>>> Have you run the tests with this patch?  It seems that it breaks
>>> quite a lot of them, including t5500, t5503, t5510, among others.
>>
>> I guess it's caused by builtin/fetch.c:backfill_tags(). And the call
>> could be replaced with
>>
>> transport_set_option(transport, TRANS_OPT_DEPTH, NULL);
>>
>
> Not sure what you mean,
> https://github.com/git/git/blob/master/t/t5550-http-fetch.sh doesn't
> call backfill_tags. What do you mean?
I wrote "I guess" ;-) I did not check what t5550 does.
>
> Thanks
>
-- 
Duy
Previous: Andrés G. AragonesesNext: Andrés G. Aragoneses
Message 11 of 16 in “transport: Catch non positive --depth option value”
  1. transport: Catch non positive --depth option valueAndrés G. Aragoneses, Nov 13, 2013
  2. Duy NguyenNov 16, 2013
  3. Junio C HamanoNov 18, 2013
  4. [PATCHv2] transport: Catch non positive --depth option valueAndrés G. Aragoneses, Nov 18, 2013
  5. Junio C HamanoNov 19, 2013
  6. [PATCHv3] transport: Catch non positive --depth option valueAndrés G. Aragoneses, Nov 21, 2013
  7. Junio C HamanoNov 21, 2013
  8. Junio C HamanoNov 21, 2013
  9. Duy NguyenNov 22, 2013
  10. Andrés G. AragonesesNov 25, 2013
  11. Duy NguyenNov 26, 2013
  12. Andrés G. AragonesesNov 26, 2013
  13. Duy NguyenNov 26, 2013
  14. [PATCHv4] transport: Catch non positive --depth option valueAndrés G. Aragoneses, Nov 26, 2013
  15. Jonathan NiederNov 26, 2013
  16. Junio C HamanoNov 26, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.