From: Duy Nguyen <pclouds@gmail.com>
Date: Tue, 26 Nov 2013 03:06:47 GMT
Subject: Re: [PATCHv3] transport: Catch non positive --depth option value
Message-ID: <CACsJy8BV74W63Sak-j_9RMjp_5Bo8HMd3Xc93GTtSn4yWStfEA@mail.gmail.com>
In-Reply-To: <5293DE93.3020008@gmail.com>

On Tue, Nov 26, 2013 at 6:34 AM, "Andrés G. Aragoneses"
<knocte@gmail.com> wrote:
> On 22/11/13 02:18, Duy Nguyen wrote:
>> On Fri, Nov 22, 2013 at 3:18 AM, Junio C Hamano <gitster@pobox.com> wrote:
>>> Have you run the tests with this patch?  It seems that it breaks
>>> quite a lot of them, including t5500, t5503, t5510, among others.
>>
>> I guess it's caused by builtin/fetch.c:backfill_tags(). And the call
>> could be replaced with
>>
>> transport_set_option(transport, TRANS_OPT_DEPTH, NULL);
>>
>
> Not sure what you mean,
> https://github.com/git/git/blob/master/t/t5550-http-fetch.sh doesn't
> call backfill_tags. What do you mean?

I wrote "I guess" ;-) I did not check what t5550 does.

>
> Thanks
>



-- 
Duy