Re: [PATCH] transport: Catch non positive --depth option value

From: Duy Nguyen <pclouds@gmail.com>
Date: Nov 16, 2013, 02:58 UTC
Message-ID: <CACsJy8BQr_9YEZq=ydz44w=9d8d5XpBDTLeXNnui7AVrMuDd3A@mail.gmail.com>
In-Reply-To: <5283A380.9030308@gmail.com>

On Wed, Nov 13, 2013 at 11:06 PM, "Andrés G. Aragoneses" <knocte@gmail.com> wrote:

Show 8 quoted lines

> Instead of simply ignoring the value passed to --depth
> option when it is zero or negative, now it is caught
> and reported.
>
> This will let people know that they were using the
> option incorrectly (as depth<0 should be simply invalid,
> and under the hood depth==0 didn't mean 'no depth' or
> 'no history' but 'full depth' instead).

'full depth' may be confusing (is it --unshallow?). Other than that the patch looks fine.

Show 24 quoted lines

>
> Signed-off-by: Andres G. Aragoneses <knocte@gmail.com>
> ---
>  transport.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/transport.c b/transport.c
> index 7202b77..edd63eb 100644
> --- a/transport.c
> +++ b/transport.c
> @@ -483,6 +483,8 @@ static int set_git_option(struct git_transport_options
> *opts,
>                         opts->depth = strtol(value, &end, 0);
>                         if (*end)
>                                 die("transport: invalid depth option '%s'",
> value);
> +                       if (opts->depth < 1)
> +                               die("transport: invalid depth option '%s'
> (non positive)", value);
>                 }
>                 return 0;
>         }
> --
> 1.8.1.2

-- 
Duy