Re: [PATCHv3] transport: Catch non positive --depth option value
- From
Andrés G. Aragoneses <knocte@gmail.com>
- Date
- Nov 25, 2013, 23:34 UTC
- Message-ID
- <5293DE93.3020008@gmail.com>
- In-Reply-To
- <CACsJy8B0qBmBkx0n2B=ivUqZTgVz-ZLhTQ_nVJ4AV0njnZksfw@mail.gmail.com>
On 22/11/13 02:18, Duy Nguyen wrote:
Show 9 quoted lines
> On Fri, Nov 22, 2013 at 3:18 AM, Junio C Hamano <gitster@pobox.com> wrote: >> Have you run the tests with this patch? It seems that it breaks >> quite a lot of them, including t5500, t5503, t5510, among others. > > I guess it's caused by builtin/fetch.c:backfill_tags(). And the call > could be replaced with > > transport_set_option(transport, TRANS_OPT_DEPTH, NULL); >
Not sure what you mean, https://github.com/git/git/blob/master/t/t5550-http-fetch.sh doesn't call backfill_tags. What do you mean?
Thanks