git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v5 00/11] add performance tracing facility

From
Duy Nguyen <pclouds@gmail.com>
Date
Jun 26, 2014, 01:11 UTC
Message-ID
<CACsJy8AoDJLMbhG82AMnt61hK_DoXQ16SY_M2J_XnUuTamv0qQ@mail.gmail.com>
In-Reply-To
<53AAE17A.7050500@gmail.com>
On Wed, Jun 25, 2014 at 9:49 PM, Karsten Blees <karsten.blees@gmail.com> wrote:
Show 17 quoted lines
> Am 25.06.2014 16:28, schrieb Duy Nguyen:
>> On Wed, Jun 11, 2014 at 2:55 PM, Karsten Blees <karsten.blees@gmail.com> wrote:
>>> Here's v5 of the performance tracing patch series, now including a bunch of cleanups and adding timestamp, file and line to all trace output.
>>>
>>> I'm particularly interested in feedback for the output format. As file names have different lengths, printing file:line as prefix results in unaligned output:
>>>
>>>  > GIT_TRACE=1 git stash list
>>>  00:12:10.544266 git.c:512 trace: exec: 'git-stash' 'list'
>>>  00:12:10.544266 run-command.c:337 trace: run_command: 'git-stash' 'list'
>>>  00:12:10.649779 git.c:312 trace: built-in: git 'rev-parse' '--git-dir'
>>
>> Can I have an (build-time) option to show <function>:<line> instead of
>> <file>:<line>? I know it's not supported by all compilers, which may
>> make support a bit cumbersome..
>>
>
> Is this really useful? <file>:<line> is unique, but <function>:<line> is not. E.g. in case of "hash_name:47" you'd have to guess if its the one in attr.c or name-hash.c...

It depends on your view. If I'm tracing a certain operation, function names let me know roughly what's going on without looking at the code because all (or many of) the names and their purposes are already in my mind. But for publishing the traces, then I agree <file>:<line> is better.

-- 
Duy

-- 
-- 
*** Please reply-to-all at all times ***
*** (do not pretend to know who is subscribed and who is not) ***
*** Please avoid top-posting. ***
The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.

You received this message because you are subscribed to the Google
Groups "msysGit" group.
To post to this group, send email to msysgit@googlegroups.com
To unsubscribe from this group, send email to
msysgit+unsubscribe@googlegroups.com
For more options, and view previous threads, visit this group at
http://groups.google.com/group/msysgit?hl=en_US?hl=en

--- 
You received this message because you are subscribed to the Google Groups "msysGit" group.
To unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Previous: Karsten Blees
Message 23 of 23 in “add performance tracing facility”
  1. 00/11 add performance tracing facilityKarsten Blees, Jun 11, 2014
  2. 01/11 trace: move trace declarations from cache.h to new trace.hKarsten Blees, Jun 11, 2014
  3. 02/11 trace: consistently name the format parameterKarsten Blees, Jun 11, 2014
  4. 03/11 trace: remove redundant printf format attributeKarsten Blees, Jun 11, 2014
  5. 04/11 trace: factor out printing to the trace fileKarsten Blees, Jun 11, 2014
  6. 05/11 trace: add infrastructure to augment trace output with additional infoKarsten Blees, Jun 11, 2014
  7. 06/11 trace: add current timestamp to all trace outputKarsten Blees, Jun 11, 2014
  8. 07/11 trace: move code around, in preparation to file:line outputKarsten Blees, Jun 11, 2014
  9. 08/11 trace: add 'file:line' to all trace outputKarsten Blees, Jun 11, 2014
  10. 09/11 trace: add high resolution timer function to debug performance issuesKarsten Blees, Jun 11, 2014
  11. Karsten BleesJun 11, 2014
  12. Junio C HamanoJun 17, 2014
  13. Karsten BleesJun 18, 2014
  14. 10/11 trace: add trace_performance facility to debug performance issuesKarsten Blees, Jun 11, 2014
  15. Junio C HamanoJun 17, 2014
  16. Karsten BleesJun 18, 2014
  17. Junio C HamanoJun 18, 2014
  18. 11/11 git: add performance tracing for git's main() function to debug scriptsKarsten Blees, Jun 11, 2014
  19. Junio C HamanoJun 12, 2014
  20. Karsten BleesJun 18, 2014
  21. Duy NguyenJun 25, 2014
  22. Karsten BleesJun 25, 2014
  23. Duy NguyenJun 26, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.