Re: [PATCH v5 00/11] add performance tracing facility
Am 25.06.2014 16:28, schrieb Duy Nguyen:
Show 14 quoted lines
> On Wed, Jun 11, 2014 at 2:55 PM, Karsten Blees <karsten.blees@gmail.com> wrote:
>> Here's v5 of the performance tracing patch series, now including a bunch of cleanups and adding timestamp, file and line to all trace output.
>>
>> I'm particularly interested in feedback for the output format. As file names have different lengths, printing file:line as prefix results in unaligned output:
>>
>> > GIT_TRACE=1 git stash list
>> 00:12:10.544266 git.c:512 trace: exec: 'git-stash' 'list'
>> 00:12:10.544266 run-command.c:337 trace: run_command: 'git-stash' 'list'
>> 00:12:10.649779 git.c:312 trace: built-in: git 'rev-parse' '--git-dir'
>
> Can I have an (build-time) option to show <function>:<line> instead of
> <file>:<line>? I know it's not supported by all compilers, which may
> make support a bit cumbersome..
>
Is this really useful? <file>:<line> is unique, but <function>:<line> is not. E.g. in case of "hash_name:47" you'd have to guess if its the one in attr.c or name-hash.c...
--
--
*** Please reply-to-all at all times ***
*** (do not pretend to know who is subscribed and who is not) ***
*** Please avoid top-posting. ***
The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.
You received this message because you are subscribed to the Google
Groups "msysGit" group.
To post to this group, send email to msysgit@googlegroups.com
To unsubscribe from this group, send email to
msysgit+unsubscribe@googlegroups.com
For more options, and view previous threads, visit this group at
http://groups.google.com/group/msysgit?hl=en_US?hl=en
---
You received this message because you are subscribed to the Google Groups "msysGit" group.
To unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Karsten Blees <karsten.blees@gmail.com>